[MOB-9899]: Add Auth Checks Before API Calls #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AUT_main_bug_bash
ts-nguyen
approved these changes
Oct 15, 2024
src/embedded/embeddedManager.ts
Outdated
Comment on lines
31
to
34
| if (typeOfAuth !== null) { | ||
| await this.retrieveEmbeddedMessages(packageName, placementIds || []); | ||
| callback(); | ||
| } |
There was a problem hiding this comment.
should we throw an error in the case of no auth?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket(s) if any
Description
Adds
typeOfAuthverification before API calls. With AUT, it's possible folks try to make these calls before being initialized more frequently. Should be helpful regardless of AUT.Test Steps